Make precompile
and can_precompile
not take self
#776
+171
−99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that
precompile
andcan_precompile
do not take self.The main intention is that ideally we would not need an engine to precompile.
If a runtime can precompile without instantiating the wasm runtime, that would be ideal.
This would allow us to move all engine creation inside of the zygote process.
This makes tests a bit more finicky, as configuring the fake engine is not as simple.
However, the non-test code changes are rather straight forward.
This is marked as draft as I'm still exploring options.