Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump telemetry and tracing dependencies #712

Merged
merged 1 commit into from
Nov 3, 2024
Merged

chore(deps): Bump telemetry and tracing dependencies #712

merged 1 commit into from
Nov 3, 2024

Conversation

jprendes
Copy link
Collaborator

This PR:

  • bump the telemetry and tracing dependencies
  • removes the unused ttrpc-condegen dependency (leftover from the daemon shim)
  • removes the ttrpc dependency and uses the containerd_shim::protos::ttrpc re-export

It replicates the previous behaviour from the opentelemetry-otlp, in calling the Tracer as "opentelemetry-otlp"

@jprendes jprendes requested a review from Mossaka October 31, 2024 16:25
Mossaka
Mossaka reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run an example to see if the traces are working with this update?

Cargo.toml Show resolved Hide resolved
Mossaka
Mossaka reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run an example to see if the traces are working with this update?

crates/containerd-shim-wasm/Cargo.toml Outdated Show resolved Hide resolved
@jprendes jprendes marked this pull request as draft October 31, 2024 20:27
@jprendes jprendes marked this pull request as ready for review November 1, 2024 15:21
Mossaka
Mossaka reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Can you include this change to the CHANGELOG?

@jprendes
Copy link
Collaborator Author

jprendes commented Nov 1, 2024

Great work! Can you include this change to the CHANGELOG?

Done!

@jprendes jprendes requested a review from Mossaka November 2, 2024 00:16
@jprendes jprendes force-pushed the bump-dependencies branch 4 times, most recently from 6dfe01f to ab2b61d Compare November 3, 2024 09:34
Mossaka
Mossaka approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Mossaka Mossaka merged commit f38990d into containerd:main Nov 3, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mossaka Mossaka Mossaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprendes @Mossaka