Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase k8s tests timeout #709

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

jprendes
Copy link
Collaborator

@jprendes jprendes commented Oct 31, 2024

This PR attempts to fix the CI sporadic failures by increasing the timeout when waiting for the deployment to be available in the k8s tests.

@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
Signed-off-by: Jorge Prendes <[email protected]>
@jprendes jprendes changed the title [DO NOT MERGE] Increase k8s tests timeout by 3 times Increase k8s tests timeout Oct 31, 2024
@jprendes jprendes marked this pull request as ready for review October 31, 2024 14:12
@jprendes jprendes requested a review from Mossaka October 31, 2024 15:15
@jprendes jprendes closed this Oct 31, 2024
@jprendes jprendes reopened this Oct 31, 2024
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! How did your experiment go? Let me know if your PR is ready to merge.

@jprendes
Copy link
Collaborator Author

No failures in 10 CI runs with the x3 timeouts.
No failures in 2 runs with somewhat tighter timeouts.

@jprendes
Copy link
Collaborator Author

If CI passes, it will have passed 10 times with the tighter timeouts, and I'm happy for this to be merged. @Mossaka

@jprendes
Copy link
Collaborator Author

These are the previous successful runs with commit ba29e9b
Screenshot_20241031_232714_Chrome

@Mossaka Mossaka merged commit 266cd7e into containerd:main Oct 31, 2024
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants