feat(wasmtime): support wasi:http/proxy world in wasmtime shim #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiltd
force-pushed
the
wasi-http
branch
2 times, most recently
from
131e0b5 to
74b24e7
Compare
Mossaka
reviewed
Oct 7, 2024
andreiltd
force-pushed
the
wasi-http
branch
5 times, most recently
from
dfae7d6 to
9548e83
Compare
Mossaka
reviewed
Oct 11, 2024
andreiltd
force-pushed
the
wasi-http
branch
2 times, most recently
from
563426c to
64ffcbf
Compare
Mossaka
reviewed
Oct 15, 2024
andreiltd
changed the title
andreiltd
commented
Oct 16, 2024
Mossaka
previously approved these changes
Oct 21, 2024
jprendes
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks @andreiltd, this is great work, and a great feature!
I left a few comments, but I don't think we need to address all of them here.
| resource_table: ResourceTable::default(), | ||
| }; | ||
| Ok(wasi_data) | ||
| pub(crate) fn envs_from_ctx(ctx: &impl RuntimeContext) -> Vec<(String, String)> { |
There was a problem hiding this comment.
thought: I'm inclined to think that this functionality should be part of the context, but not sure what name it should have.
Mossaka
reviewed
Oct 24, 2024
|
Here is a follow up PR that implements a graceful server shutdown: https://github.com/andreiltd/runwasi/pull/1/files |
andreiltd
force-pushed
the
wasi-http
branch
2 times, most recently
from
6b51a1b to
ea036fa
Compare
Mossaka
previously approved these changes
Oct 25, 2024
Mossaka
approved these changes
Oct 25, 2024
jprendes
approved these changes
Oct 25, 2024
|
🥂 thanks for working on this, @andreiltd ! |
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #401.
The patch introduces initial support for the
wasi:http/proxyworld in thewasmtimeshim. The main goal is to detect components targetinghttp/proxy, start up ahyperserver to listen for incoming connections, and forward the incoming requests to the WASM component for handling. This behavior is very similar to what thewasmtime servecommand currently offers. The server task is terminated upon receiving a terminate or interrupt signal in the container.The server can be customized by setting environment variables passed to the RuntimeContext. These variables include:
WASMTIME_HTTP_PROXY_SOCKET_ADDR: Defines the socket address to bind to (default: 0.0.0.0:8080).WASMTIME_HTTP_PROXY_BACKLOG: Defines the maximum number of pending connections in the queue (default: 100).The compiled WASM component targeting
wasi:http/proxyworld has been integrated into thetest-modulescrate. This allows us to validate the functionality in the integration tests.Closes: #416