-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Scripts for setup new dev environment #680
Conversation
Thanks for fixing this bug! I just realized that our build pipeline is not set up correctly to fail when the |
I can try to address that as well in this PR if you would like. |
that would be nice! I briefly looked into it with #682 , and suprisingly found that |
@@ -1,6 +1,6 @@ | |||
#!/bin/bash | |||
sudo apt -y update | |||
sudo apt install -y pkg-config libsystemd-dev libdbus-glib-1-dev build-essential libelf-dev libseccomp-dev libclang-dev libzstd-dev protobuf-compiler | |||
sudo apt install -y pkg-config libsystemd-dev libdbus-glib-1-dev build-essential libelf-dev libseccomp-dev libclang-dev libzstd-dev protobuf-compiler libssl-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add libssl
dep to cross/Dockerfile_*
as well?
Signed-off-by: jiaxiao zhou <[email protected]>
I setup a new dev environment and wanted to get the project running on my OSX machine. I installed a fresh Linux VM and was able to run
make build
andmake test
with this setup.I encountered one test failure. I don't believe this failure would only impact me as the oci_spec default for environment variables sets 2 environment variables. So I set the