Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for Wasm OCI artifact #661

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Aug 9, 2024

This is a follow up to #631 and adds tests to test the artifact type defined at https://tag-runtime.cncf.io/wgs/wasm/deliverables/wasm-oci-artifact/

This mostly worked out of the box. A couple minor notes that will be working to resolve upstream:

  • Using the containerd CRI interface works with this, containenrd CTR has a bug in it that blocks this being used.
  • The pod spec also needs a command specified otherwise the pod will not start.

Signed-off-by: James Sturtevant <[email protected]>
@jsturtevant
Copy link
Contributor Author

smoke test failed with

ctr: failed to start shim: start failed: failed to create TTRPC connection: dial unix OpenTelemetry trace error occurred. error sending request for url (http://localhost:4318/v1/traces): error trying to connect: tcp connect error: Connection refused (os error 111)

@jsturtevant jsturtevant closed this Aug 9, 2024
@jsturtevant jsturtevant reopened this Aug 9, 2024
@jsturtevant
Copy link
Contributor Author

There are definitely some instability but I don't believe it is related to these changes or #631:

2 out of three pods started in the e2e (not oci artifact related):

default              wasi-demo-6c5dcf6ddb-47qjh                              2/2     Running             0          [8](https://github.com/containerd/runwasi/actions/runs/10326209465/job/28589545828?pr=661#step:8:9)2s
default              wasi-demo-6c5dcf6ddb-6qh8s                              2/2     Running             0          82s
default              wasi-demo-6c5dcf6ddb-b6trr                              0/2     ContainerCreating   0          82s

looking into the logs the pod with wasm started: default_wasi-demo-6c5dcf6ddb-b6trr_c486fffe-6491-4731-af1c-a44df3603288 but the other one seems to have errors:

Aug 09 22:07:29 containerd-wasm-control-plane containerd[210]: time="2024-08-09T22:07:29.871600750Z" level=error msg="collecting metrics for e1788b4f7ae9ee221c7a5196d62b05e5c50572009d750438c240215ca43a21d1" error="task is not running: invalid argument"
Aug 09 22:07:03 containerd-wasm-control-plane containerd[210]: time="2024-08-09T22:07:03.041875285Z" level=error msg="loading cgroup for 377" error="cgroups: cannot find cgroup mount destination"

@jsturtevant
Copy link
Contributor Author

/assign @devigned

Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@devigned devigned merged commit 90980f5 into containerd:main Aug 13, 2024
152 of 156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants