Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RPITIT in PathResolve #654

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Use RPITIT in PathResolve #654

merged 2 commits into from
Jul 23, 2024

Conversation

primoly
Copy link
Contributor

@primoly primoly commented Jul 23, 2024

As the return-position impl trait in trait (RPITIT) feature is stable since Rust 1.75.0

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Could you also update the impl block? The methods from line 35 onwards.

@@ -13,10 +9,10 @@ pub trait PathResolve {
// Further contraints can be added by calling filtering the returned iterator.
fn resolve_in_dirs<'a>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'a is not needed anymore, right?

Suggested change
fn resolve_in_dirs<'a>(
fn resolve_in_dirs(

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Mossaka Mossaka merged commit 62f5750 into containerd:main Jul 23, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants