Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for running sed on Linux for release pipeline #533

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

jsturtevant
Copy link
Contributor

Release failed because sed is different on Linux/macos 🤕

Also adds https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#run-name so can see what ran with out having to open the action logs

Signed-off-by: James Sturtevant <[email protected]>
@jsturtevant jsturtevant requested a review from devigned March 29, 2024 20:48
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -1,4 +1,5 @@
name: release
run-name: Release ${{ inputs.crate }} with v@${{ inputs.version }} (DryRun - ${{ inputs.dry_run }})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@devigned devigned merged commit 7af576f into containerd:main Mar 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants