-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): remove the network ns in the shim start #503
Conversation
fed8eab
to
eabc519
Compare
The previous run failed, Did something change? |
Not really. Let me run the tests again |
1 / 5 runs the CI failed |
eabc519
to
680095b
Compare
this commit removes the unnecessary nerwork namepsace setup in the shim start function because it is already been set in youki Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
680095b
to
c3d4072
Compare
Signed-off-by: jiaxiao zhou <[email protected]>
That timeout error is linked to installing a debian package, so it can be ignored. |
@Mossaka , do you ha e a feel from all the runs you did if there are still failures linked to this? If so, what kind of failures? I'm inclined to think that any failures are just the sporadic timeouts we've seen in other places in CI as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm happy with merging this. We csn revert if we notice any issues afterwards.
I believe all the failures are related to the sporadic timeouts |
this commit removes the unnecessary nerwork namepsace setup in the shim start function because it is already been set in youki.
See #476