Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): remove the network ns in the shim start #503

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Mar 5, 2024

this commit removes the unnecessary nerwork namepsace setup in the shim start function because it is already been set in youki.

See #476

@Mossaka Mossaka force-pushed the remove-network-ns branch from fed8eab to eabc519 Compare March 5, 2024 00:13
@Mossaka Mossaka closed this Mar 5, 2024
@Mossaka Mossaka reopened this Mar 5, 2024
@jsturtevant
Copy link
Contributor

The previous run failed, Did something change?

@Mossaka
Copy link
Member Author

Mossaka commented Mar 15, 2024

The previous run failed, Did something change?

Not really. Let me run the tests again

@Mossaka Mossaka closed this Mar 15, 2024
@Mossaka Mossaka reopened this Mar 15, 2024
@Mossaka Mossaka closed this Apr 10, 2024
@Mossaka Mossaka reopened this Apr 10, 2024
@Mossaka Mossaka closed this Apr 11, 2024
@Mossaka Mossaka reopened this Apr 11, 2024
@Mossaka
Copy link
Member Author

Mossaka commented Apr 16, 2024

1 / 5 runs the CI failed

Mossaka and others added 2 commits November 15, 2024 06:01
this commit removes the unnecessary nerwork namepsace setup in the
shim start function because it is already been set in youki

Signed-off-by: jiaxiao zhou <[email protected]>
@Mossaka
Copy link
Member Author

Mossaka commented Nov 16, 2024

@Mossaka Mossaka requested a review from jprendes November 16, 2024 03:25
@jprendes
Copy link
Collaborator

That timeout error is linked to installing a debian package, so it can be ignored.

@jprendes
Copy link
Collaborator

@Mossaka , do you ha e a feel from all the runs you did if there are still failures linked to this? If so, what kind of failures? I'm inclined to think that any failures are just the sporadic timeouts we've seen in other places in CI as well.

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'm happy with merging this. We csn revert if we notice any issues afterwards.

@Mossaka
Copy link
Member Author

Mossaka commented Nov 16, 2024

@Mossaka , do you ha e a feel from all the runs you did if there are still failures linked to this? If so, what kind of failures? I'm inclined to think that any failures are just the sporadic timeouts we've seen in other places in CI as well.

I believe all the failures are related to the sporadic timeouts

@Mossaka Mossaka merged commit 7a6463c into containerd:main Nov 16, 2024
56 checks passed
@Mossaka Mossaka deleted the remove-network-ns branch November 17, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants