Add tests for k8s and fix cgroup issue #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
cg2_subtree_parents
branch
from
80df55e to
0af69a6
Compare
This tests running a deployment against a k8s cluster (created by kind). Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
cg2_subtree_parents
branch
from
0af69a6 to
b55fb33
Compare
By skipping parents we were hitting an issue with the way k8s cgroups are managed since it is creating those cgroups. This change ensures we apply subtree_control to all parents as needed. Before this change pods would fail to start due to missing `cpu.weight` since we were not delegating cgroup control. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
cg2_subtree_parents
branch
from
b55fb33 to
34c1a64
Compare
|
Is this PR solving issue #40 ? |
|
No this only solves a cgroupv2 issue. I need to work out how to test both cgroupv1 and cgroupv2 since this is entirely dependent on the node the tests are running on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for descriptions.