Add guidance for adding and removing shims from project #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jsturtevant
force-pushed
the
shim-add-remove
branch
from
538288c to
660b59b
Compare
cpuguy83
requested changes
Nov 30, 2023
rumpl
reviewed
Dec 1, 2023
Mossaka
reviewed
Dec 5, 2023
Signed-off-by: James Sturtevant <[email protected]>
Co-authored-by: Brian Goff <[email protected]> Signed-off-by: James Sturtevant <[email protected]>
Co-authored-by: Djordje Lukic <[email protected]> Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
shim-add-remove
branch
from
6eb531d to
3e27e77
Compare
Mossaka
approved these changes
Jan 18, 2024
|
I can merge this in if you want |
cpuguy83
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #400