remove wasmedge-sys dependency #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
wasmedge-sys.This depdency was only used to test that a symbol is statically / dinamically linked in the binary.
This PR inlines the FFI symbol instead of using the crate dependency.
The risk of depending on
wasmedge-sysis that the version could drifts from whatwasmedge-sdkuses.In that case, the test would be probing the wrong symbol, and it may silenly succeed when it should fail.
The selected symbol for the probe is expected to remain unchaged across different versions of wasmedge.
If it ever changes, then compilation should fail, indicating that the symbol needs to be updated.