Fix issue running k8s and cross locally #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
requested changes
Oct 20, 2023
There was a problem hiding this comment.
I don't think we need a wrapper script.
We are already specifying the target in the Makefile with TARGET_FLAG.
It's just a matter of adding --target-dir=./target/build/$(TARGET) to TARGET_FLAG.
You also need to use the same target-dir in the install-% rule (IIUC, that's why CI failed).
I propose we use a new makefile variable TARGET_DIR, and we set it to ./target/build/$(TARGET) when using cross or to ./target otherwise.
|
looks like latest failures is due to cross setting. This is working locally when I run it, with same setting 👀 |
jsturtevant
force-pushed
the
fix-local-cluster
branch
4 times, most recently
from
125da87 to
e2cd07a
Compare
jprendes
reviewed
Oct 20, 2023
Mossaka
approved these changes
Oct 21, 2023
Signed-off-by: James Sturtevant <[email protected]> Signed-off-by: Jorge Prendes <[email protected]> Co-authored-by: Jorge Prendes <[email protected]>
jsturtevant
force-pushed
the
fix-local-cluster
branch
from
c78c864 to
99c3951
Compare
|
I am trying to get |
|
Merging it in now. The progress on my side is slow and I don't want to block the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues after #359 when running
make test/k8s-wasmtimelocally.First, the
TARGETis not being set properly. SinceTARGETwas already set when re-invoking$(MAKE)it gets the prior value. Example output:Second, cross has issues when switching targets: https://github.com/cross-rs/cross/wiki/FAQ#glibc-version-error. I ran into this only my local set up, where the first step of cross (after fixing the above) would error out with
This also adds a
cleantarget which allows for testing this scenario, otherwise several of the steps get skipped since they already compiled.