Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cross-rs #332

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Use cross-rs #332

merged 1 commit into from
Oct 3, 2023

Conversation

jprendes
Copy link
Collaborator

@jprendes jprendes commented Sep 22, 2023

This PR enables the use of cross-rs for building and testing.

make build-wasmedge CARGO=cross TARGET=x86_64-unknown-linux-musl

It also works as an example on how to set up the cross containers for building runwasi with libseccomp

This PR depends on #331 as otherwise wasmedge wouldn't build on musl targets.

Note that the release workflows are not using cross-rs which can be done in a follow up PR.

@jprendes jprendes force-pushed the use-cross branch 2 times, most recently from 64c75ee to 5f0947f Compare September 24, 2023 21:10
@jprendes
Copy link
Collaborator Author

We've used this to build the x86_64 and aarch64 binaries we ship with Docker Desktop.
https://github.com/rumpl/containerd-wasi-shims/blob/main/.github/workflows/build-runwasi.yml#L31

Makefile Show resolved Hide resolved
Signed-off-by: Jorge Prendes <[email protected]>
@jsturtevant
Copy link
Contributor

LGTM

Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@devigned devigned merged commit ec65b3f into containerd:main Oct 3, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants