-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support wasmedge plugins #307
feat: Support wasmedge plugins #307
Conversation
caff532
to
30ddec5
Compare
30ddec5
to
901668c
Compare
0216e3b
to
4c4e9cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added a few comments.
Where are the plugins supposed to be found? If inside the container image, I don't see why we need to fiddle with the mount points, as libcontainer will have already handled that for us. |
The plugin is a .so file loaded through |
19c7489
to
8080010
Compare
8080010
to
8efdf4d
Compare
The statically linked version is also about to support plugin functionality, but the changes made only depend on the Wasmedge library. Therefore, after merging this PR, upstream will only need to await the release of the new SDK version to enable it in both ways. |
Signed-off-by: vincent <[email protected]>
8efdf4d
to
1125143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank you, @CaptainVincent.
It's a feature PR
By the way, please note that this feature currently only functions when dynamically linking the WasmEdge library to the WasmEdge shim.
For building this, you can use the following command:
cargo build --package containerd-shim-wasmedge --no-default-features
In addition, I have provided all the WasmEdge runtime demo cases via containerd (here), including the
wasinn plugin
demo related to this feature. Considering that these demos may only be supported with the WasmEdge shim, I plan to relocate and maintain them under the WasmEdge or Second State Org's repository. At the same time, I will ensure that they run demos daily in CI and guarantee that these demos are always executed based on the latest upstream code.