Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate setup steps to keep in sync #244

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

jsturtevant
Copy link
Contributor

This consolidates the scripts and came out of #238 (comment).

Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jsturtevant !

scripts/setup.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Mossaka
Mossaka previously approved these changes Aug 17, 2023
@Mossaka
Copy link
Member

Mossaka commented Aug 17, 2023

It looks like the CI is failing

@jprendes
Copy link
Collaborator

jprendes commented Aug 17, 2023

It looks like the CI is failing

I can look into it in a few hours. (commented in the wrong PR)

@Mossaka Mossaka merged commit 6287dff into containerd:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants