Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundent cache #189

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Jul 20, 2023

PR #185 changes action from actions-rs/toolchain@v1 to actions-rust-lang/setup-rust-toolchain@v1

There is a key difference between these two actions and that is cache. actions-rust-lang/setup-rust-toolchain@v1 defaults to use "Swatinem/rust-cache", but we already have used this in the CI.

So this PR removes the redundent cache steps, and disables the rust-cache action in the release CI.

Signed-off-by: jiaxiao zhou <[email protected]>
@Mossaka Mossaka closed this Jul 20, 2023
@Mossaka Mossaka reopened this Jul 20, 2023
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 85f71e8 into containerd:main Jul 21, 2023
@Mossaka Mossaka deleted the delete-redundent-cache branch July 21, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants