Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshotter: add flag to specify nydus-overlayfs path #615

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

katexochen
Copy link
Contributor

This allows installation of multiple nydus-overlayfs versions on the same machine.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 21.73913% with 18 lines in your changes missing coverage. Please review.

Project coverage is 22.07%. Comparing base (4f4dbcd) to head (50a833f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
snapshot/mount_option.go 0.00% 10 Missing ⚠️
snapshot/snapshot.go 0.00% 6 Missing ⚠️
config/config.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #615   +/-   ##
=======================================
  Coverage   22.07%   22.07%           
=======================================
  Files         122      122           
  Lines       10746    10766   +20     
=======================================
+ Hits         2372     2377    +5     
- Misses       8054     8068   +14     
- Partials      320      321    +1     
Files with missing lines Coverage Δ
internal/flags/flags.go 100.00% <100.00%> (ø)
config/config.go 36.28% <0.00%> (-0.66%) ⬇️
snapshot/snapshot.go 0.00% <0.00%> (ø)
snapshot/mount_option.go 23.43% <0.00%> (-0.82%) ⬇️

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe also add the option into misc/snapshotter/config.toml. :)

@katexochen
Copy link
Contributor Author

LGTM! Maybe also add the option into misc/snapshotter/config.toml. :)

Thanks, done! :)

This allows installation of multiple nydus-overlayfs versions on the same machine.

Signed-off-by: Paul Meyer <[email protected]>
@imeoer imeoer merged commit d42d55a into containerd:main Sep 9, 2024
16 checks passed
@katexochen katexochen deleted the nydus-overlayfs-path branch September 9, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants