misc: merge chmod into copy in Dockerfile #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure the broken CI is related with the PR. |
Let's use Docker's `COPY --chmod` feature instead of using a separate chmod command. This will reduce the generated image size by ~12KB. Fixes: containerd#402 Signed-off-by: Yifan Zhao <[email protected]>
|
Sorry for the late reply! It seems that COPY --chmod in Docker buildkit only supports octal notation instead of "+x". [1] This was my mistake and I've updated the new patch. It looks like the current version could pass the CI correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use Docker's
COPY --chmodfeature instead of using a separate chmod command. This will reduce the generated image size by ~12KB.Fixes: #402