converter: support appending files to bootstrap layer #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
force-pushed
the
converter-bootstrap-append
branch
from
38134c1
to
d5bcec0
Compare
Support `AppendFiles` option on `converter.Merge` method, `AppendFiles` specifies the files that need to be appended to the bootstrap layer. This option allows the user to place some files in the nydus bootstrap layer, for example, the user can place metadata info generated at build time, e.g. named `image/metadata.json`. And this usage does not affect the `image/image.boot` bootstrap file that is accessed by the nydus runtime. Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
converter-bootstrap-append
branch
from
d5bcec0
to
52145e6
Compare
Fix the clippy check errors like: ``` warning: field `0` is never read --> src/main.rs:79:8 | 79 | IO(io::Error), | -- ^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 79 | IO(()), | ~~ ``` Signed-off-by: Yan Song <[email protected]>
imeoer
requested review from
changweige and
sctb512
and removed request for
changweige
|
LGTM. Is there any example for this PR? |
sctb512
approved these changes
Apr 25, 2024
adamqqqplay
approved these changes
Apr 26, 2024
Haven't yet, will submit in another PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
AppendFilesoption onconverter.Mergemethod,AppendFilesspecifies the files that need to be appendedto the bootstrap layer.
This option allows the user to place some files in the nydus
bootstrap layer, for example, the user can place metadata
info generated at build time, e.g. named
image/metadata.json.And this usage does not affect the
image/image.bootbootstrapfile that is accessed by the nydus runtime.