converter: improve pack performance by fifo #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
force-pushed
the
converter-tar-pack
branch
2 times, most recently
from
a8db324 to
f8e5006
Compare
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 35.09% 35.09%
=======================================
Files 18 18
Lines 1288 1288
=======================================
Hits 452 452
Misses 765 765
Partials 71 71 Continue to review full report at Codecov.
|
imeoer
force-pushed
the
converter-tar-pack
branch
from
396d2d6 to
7621e81
Compare
|
Wait for this PR dragonflyoss/nydus#415 to be merged then pass the CI testing. |
In the previous convert implementation, the builder (nydus-image) would dump the blob and bootstrap, and then the converter would pack the two files into a tar format, which has a performance loss, and the patch solves this problem by introducing fifo file. The converter creates a fifo file, the builder will write the blob and bootstrap data to the fifo as the writer side, then the converter read from the fifo and write directly to content store for faster conversion. Signed-off-by: Yan Song <[email protected]>
The latest nydus static release url has been changed. Signed-off-by: Yan Song <[email protected]>
eryugey
approved these changes
May 6, 2022
bergwolf
reviewed
May 9, 2022
| } | ||
| defer blobFifo.Close() |
There was a problem hiding this comment.
blobFifo is closed upon convert error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous convert implementation, the builder (nydus-image) would
dump the blob and bootstrap, and then the converter would pack the two
files into a tar format, which has a performance loss, this patch solves this
problem by introducing fifo file.
The converter creates a fifo file, the builder will write the blob and
bootstrap data to the fifo as the writer side, then the converter read
from the fifo and write directly to content store for faster conversion.
Related PR: dragonflyoss/nydus#415
Signed-off-by: Yan Song [email protected]