Provide make install to facilitate configuring nydus-snapshotter #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 34.37% 34.41% +0.03%
==========================================
Files 18 18
Lines 1277 1293 +16
==========================================
+ Hits 439 445 +6
- Misses 767 777 +10
Partials 71 71
Continue to review full report at Codecov.
|
eryugey
reviewed
Feb 11, 2022
eryugey
reviewed
Feb 11, 2022
eryugey
reviewed
Feb 11, 2022
eryugey
reviewed
Feb 11, 2022
changweige
force-pushed
the
make-install
branch
2 times, most recently
from
c31ec44
to
1b1c0be
Compare
imeoer
reviewed
Feb 11, 2022
Sure. All commits are prefixed now |
changweige
force-pushed
the
make-install
branch
2 times, most recently
from
626fe08
to
2cbd433
Compare
eryugey
reviewed
Feb 11, 2022
changweige
force-pushed
the
make-install
branch
from
2cbd433
to
0eab5ea
Compare
To shorten the default socket address and keep it consistent with the one in README.md Signed-off-by: Changwei Ge <[email protected]>
Thus to make it more convenient for users to install and setup nydus-snapshotter Signed-off-by: Changwei Ge <[email protected]>
Will be consumed when add/enable nydus-snapshotter service to systemd Signed-off-by: Changwei Ge <[email protected]>
Signed-off-by: Changwei Ge <[email protected]>
changweige
force-pushed
the
make-install
branch
from
0eab5ea
to
72719d9
Compare
eryugey
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users just perform
make installand downloadnydusdandnydus-imagebefore they can use nydus-snapshotter