README.md: add disable_snapshot_annotations=false in cri env #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As 'containerd config default' produce default configuration which include disable_snapshot_annotations=true, but nydus-snapshotter depend on snapshot annotation, so here we should set explicitly. Signed-off-by: luodaowen.backend <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 34.41% 34.41%
=======================================
Files 18 18
Lines 1293 1293
=======================================
Hits 445 445
Misses 777 777
Partials 71 71 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As 'containerd config default' produce default configuration
which include disable_snapshot_annotations=true, but nydus-snapshotter
depend on snapshot annotation, so here we should set explicitly.
Signed-off-by: luodaowen.backend [email protected]