cache manager: fix cache manager failure in none daemon mode #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, both AddSnapshot and DelSnapshot will not be executed in the none daemon mode. The fundamental reason is that the incoming parameter is the imageID obtained from the daemon. Now we adjust the function call path to bypass the daemon and get the imageID directly from snapshot labels. For AddSnapshot, we separate it from prepareRemoteSnapshot, run it separately, and parse the imageID directly from the snapshot label. For DelSnapshot, we advance it from Cleanup to Remove. Signed-off-by: zhaoshang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 28.44% 29.11% +0.66%
==========================================
Files 18 19 +1
Lines 1494 1604 +110
==========================================
+ Hits 425 467 +42
- Misses 1012 1075 +63
- Partials 57 62 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
imeoer
reviewed
Aug 10, 2022
| @@ -300,6 +300,11 @@ func (o *snapshotter) Prepare(ctx context.Context, key, parent string, opts ...s | |||
| } | |||
|
|
|||
| logCtx.Infof("found nydus meta layer id %s, parpare remote snapshot", id) | |||
|
|
|||
| if err := o.fs.AddSnapshot(info.Labels); err != nil { | |||
There was a problem hiding this comment.
Why only do AddSnapshot when the container running? If the user deletes the image before any container run, can nydus blobs be GC-ed?
There was a problem hiding this comment.
Okay I miss it, blob cache is generated at only container running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, both AddSnapshot and DelSnapshot will not be executed in
the none daemon mode. The fundamental reason is that the incoming
parameter is the imageID obtained from the daemon. Now we adjust the
function call path to bypass the daemon and get the imageID directly
from snapshot labels.
For AddSnapshot, we separate it from prepareRemoteSnapshot, run it
separately, and parse the imageID directly from the snapshot label.
For DelSnapshot, we advance it from Cleanup to Remove.
Signed-off-by: zhaoshang [email protected]