Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: initialize OCI LinuxMemory resources to empty. #37

Merged
merged 1 commit into from
May 4, 2023

Conversation

klihub
Copy link
Member

@klihub klihub commented May 4, 2023

When converting to OCI LinuxResources, always use an empty &LinuxMemory{} instead of a nil one. Some runtimes try to dereference it unconditionally. Leaving it unset panics on these.

When converting to OCI LinuxResources, always use an empty
&LinuxMemory{} instead of a nil one. Some runtimes try to
dereference it unconditionally. Leaving it unset panics on
these.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub requested a review from fuweid May 4, 2023 15:38
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelkarp samuelkarp merged commit 9418541 into containerd:main May 4, 2023
@klihub klihub deleted the fixes/use-empty-LinuxMemory branch May 5, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants