Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a chapter about security considerations. #36

Merged
merged 1 commit into from
May 7, 2023

Conversation

klihub
Copy link
Member

@klihub klihub commented Apr 6, 2023

Add a few paragraphs with security considerations about protecting access to the NRI socket and deploying NRI plugins as K8s DaemonSets.

@klihub klihub requested a review from fuweid April 6, 2023 08:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.16 🎉

Comparison is base (2a8b655) 63.83% compared to head (694da42) 64.00%.

❗ Current head 694da42 differs from pull request most recent head ab28e71. Consider uploading reports for the commit ab28e71 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   63.83%   64.00%   +0.16%     
==========================================
  Files           9        9              
  Lines        1800     1800              
==========================================
+ Hits         1149     1152       +3     
+ Misses        500      497       -3     
  Partials      151      151              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

README.md Show resolved Hide resolved
@samuelkarp samuelkarp requested a review from cji April 6, 2023 08:32
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@klihub klihub force-pushed the docs/protect-access-to-nri branch 2 times, most recently from 90bc7ee to fc8c0d9 Compare May 4, 2023 17:53
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for putting this together!

Add a chapeter a about security considerations and provide
a few pointers to related documentation.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub force-pushed the docs/protect-access-to-nri branch from fc8c0d9 to ab28e71 Compare May 5, 2023 05:54
Copy link

@kad kad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@cji cji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for writing this! 🎉 🎉 🎉

Copy link
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for writing this!

@samuelkarp samuelkarp merged commit 76ad849 into containerd:main May 7, 2023
@klihub klihub deleted the docs/protect-access-to-nri branch May 23, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants