-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a chapter about security considerations. #36
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 63.83% 64.00% +0.16%
==========================================
Files 9 9
Lines 1800 1800
==========================================
+ Hits 1149 1152 +3
+ Misses 500 497 -3
Partials 151 151 ☔ View full report in Codecov by Sentry. |
90bc7ee
to
fc8c0d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for putting this together!
Add a chapeter a about security considerations and provide a few pointers to related documentation. Signed-off-by: Krisztian Litkey <[email protected]>
fc8c0d9
to
ab28e71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for writing this! 🎉 🎉 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for writing this!
Add a few paragraphs with security considerations about protecting access to the NRI socket and deploying NRI plugins as K8s DaemonSets.