Remove images from Docker Hub from tests

[apostasie]

Fix #3498

[apostasie]

Note that this here is highlighting another of our test issues: we do have a number of platform specific files, but we ALSO do mark certain tests as skipped if we are on windows.

Using the two mechanisms simultaneously is problematic, and leading to situations like this here, where we have to add non-sensical definitions.

Suggestion is to stop using platform specific files for tests entirely, and instead just use appropriate Skip.

• easier to know how many / which tests are being skipped on a certain platform
• easier to enable / disable a single test for a platform without having to move a bunch of files around

[apostasie]

TestRunWithTtyAndDetached #3437

Besides that ^, it is ready.

@AkihiroSuda at your convenience.

[fahedouch]

Hi @apostasie, there is also a rate limiting on ghcr and everywhere!
A non-expensive solutions would be :

• to check if image exist in content storage before making a pull otherwise pull
• cache image list in mem struct for each pull and make a mem check for each pull.

unfortunately there is no flag that does this check in the pull subcommand

[apostasie]

Hi @apostasie, there is also a rate limiting on ghcr and everywhere! A non-expensive solutions would be :

• to check if image exist in content storage before making a pull otherwise pull
• cache image list in mem struct for each pull and make a mem check for each pull.

unfortunately there is no flag that does this check in the pull subcommand

At the start of tests, we could spin a local registry and push there the images we need.

Then we could leverage hosts.toml to use the local registry as cache during the tests.

That would limit the number of round trips to the average to once per test suite and per image...

[apostasie]

@AkihiroSuda updated to remove the fake "busybox" name and added a comment.

[apostasie]

TestRunWithTtyAndDetached
I never thought I would say that in my life, but I actually want to buy a windows laptop (just to fix this)...

[apostasie]

Hi @apostasie, there is also a rate limiting on ghcr and everywhere! A non-expensive solutions would be :

I am sure there is - we just never hit it on the CI, or debugging locally...

[apostasie]

Latest failures are the usual - TestIPFSComposeUp and TestRunWithTtyAndDetached

[AkihiroSuda]

Thanks