Fix host networking issues and rename incidental issue #3344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purported to:
--network host
,none
) #3341Does NOT fix yet #355
The take-away are:
Acquire
on the hosts store, causingUpdate
to fail during a rename operation. Note that the same is true fornone
. Rename has been modified to not hard fail anymore on hostsstore Update failures. Another PR (Rename rollback on error #3342) is also making rename able to rollback in case of failureNote that calls to CleanupNetworking and SetupNetworking were previously gated by a platform check to apply only on Windows (although not everywhere).
Now, this does not seem to serve much of a purpose, as these methods did nothing for any of the networkManager (with the exception of the Windows implementation of CNI).
Is this some kind of unfinished refactor?
Anyhow, I did remove the platform checks altogether, since the code decides already if something should happen.