Skip the BuildKit tests in the rootless integration #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jun 22, 2023
.github/workflows/test.yml
Outdated
| @@ -149,7 +149,7 @@ jobs: | |||
| - name: "Prepare (network driver=slirp4netns, port driver=builtin)" | |||
| run: DOCKER_BUILDKIT=1 docker build -t ${TEST_TARGET} --target ${TEST_TARGET} --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} . | |||
| - name: "Test (network driver=slirp4netns, port driver=builtin)" | |||
| run: docker run -t --rm --privileged ${TEST_TARGET} | |||
| run: docker run -t --rm --privileged -e WORKAROUND_CIRRUS=1 ${TEST_TARGET} | |||
There was a problem hiding this comment.
This is not Cirrus, so I guess we have to rename the var to something like WORKAROUND_ISSUE_622
There was a problem hiding this comment.
I’m also wondering if we can try other workarounds, such as using 8.8.8.8? (From my memory we might have already tried that though)
There was a problem hiding this comment.
Thanks @AkihiroSuda
It has been change to the WORKAROUND_ISSUE_622 :-)
yankay
force-pushed
the
skip_rootless_build
branch
3 times, most recently
from
9a95883 to
3534bc5
Compare
yankay
changed the title
yankay
force-pushed
the
skip_rootless_build
branch
from
3534bc5 to
f753857
Compare
Signed-off-by: Kay Yan <[email protected]>
yankay
force-pushed
the
skip_rootless_build
branch
from
f753857 to
2626a21
Compare
|
Thanks @AkihiroSuda for the PR review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#622 is too much flaky
The CI is often broken by the issue.
So like #734, skip the test in the rootless integration .