Add compose port command
#1628
Merged
Add compose port command
#1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Dec 9, 2022
| // when no port mapping is found, docker compose v1 prints `\n` while v2 prints `:0\n` | ||
| // both v1 and v2 have exit code 0 (succeess) | ||
| // nerdctl compose will fail with error (no public port fouond). | ||
| testutil.DockerIncompatible(t) |
There was a problem hiding this comment.
Can we split the incompatible part to another (sub)test?
djdongjin
force-pushed
the
compose-port
branch
from
08ab2a1 to
a5e8348
Compare
Signed-off-by: Jin Dong <[email protected]>
djdongjin
force-pushed
the
compose-port
branch
from
a5e8348 to
9271dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.docker.com/engine/reference/commandline/compose_port/
It has 2 changes:
containerutil).pkg), so that they can be reused by other commands (e.g. relevant compose command).(Please lmk if 2 doesn't look good, or any suggestion if there is better place for this kind of functions (e.g., finish a task given a container).
Also there is a incompatible behavior compared to docker compose (docker itself has incompatible behavior in v1 and v2), when a given port/protocol doesn't exist:
\n).:0\n.Please lmk if this is okay.
Signed-off-by: Jin Dong [email protected]