Add support to overlaybd convert #1517
Conversation
HileQAQ
force-pushed
the
convert
branch
15 times, most recently
from
20777a2 to
ce06425
Compare
|
@AkihiroSuda @fuweid |
| return errors.New("option --nydus conflicts with --zstdchunked") | ||
| } | ||
| if !oci { | ||
| logrus.Warnln("option --nydus should be used in conjunction with '--oci', forcibly enabling on oci mediatype for nydus conversion") |
There was a problem hiding this comment.
L188-205 to deal with convert conflict, and L260-262 to show this warning.
There was a problem hiding this comment.
Thanks, but "forcibly enabling on oci mediatype for nydus conversion" seems no longer printed
There was a problem hiding this comment.
Thanks, but "forcibly enabling on oci mediatype for nydus conversion" seems no longer printed
Sorry, it was fixed.
cmd/nerdctl/image_convert.go
Outdated
| if !oci { | ||
| logrus.Warnf("option --%s should be used in conjunction with --oci", convertType) | ||
| logrus.Warnf("option --%s should be used in conjunction with --oci, forcibly enabling on oci mediatype for %s conversion", convertType, convertType) |
There was a problem hiding this comment.
"forcibly enabling on oci mediatype" is untrue for estargz.
True for Nydus. Not sure for overlaybd.
There was a problem hiding this comment.
Sorry, it was fixed in here, mediatype with/without --oci has been confirmed.
Signed-off-by: Haoqi Miao <[email protected]>
This PR supports using nerdctl image convert to convert docker v2 or OCI images to OverlayBD images.
Before the conversion, users should have the
overlaybd-snapshotterbinary installed, which build from accelerated-container-image. They can run the command likenerdctl image convert --overlaybd --oci <source_image> <target_image>to convert a docker v2 or OCI image to a OverlayBD image whose tag is<target_image>.After the conversion, they can use the nerdctl image push command to push the converted OverlayBD image to their registry and then use the
nerdctl run --snapshotter overlaybdto run the image.Signed-off-by: Haoqi Miao [email protected]