add support for --rootless #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -655,6 +656,10 @@ func (r *Runc) args() (out []string) { | |||
| if r.SystemdCgroup { | |||
| out = append(out, "--systemd-cgroup") | |||
| } | |||
| if r.Rootless != nil { | |||
There was a problem hiding this comment.
shouldn't this be if r.Rootless != nil && *r.Rootless {
then just add the flag. I don't think --rootless true is valid, it's usually --rootless=true
There was a problem hiding this comment.
*r.Rootless is expected to be set to false when the caller wants to execute runc --rootless=false explicitly, so as to disable automatic rootless mode detection.
For example, when runc is being executed in a rootless runc, --rootless might need to be set to falseexplicitly. opencontainers/runc#1837
The --rootless flag was introduced in opencontainers/runc#1688. In most cases runc itself can detect the appropriate value, but it is considered to be there are some corner cases. Signed-off-by: Akihiro Suda <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --rootless flag was introduced in opencontainers/runc#1688.
In most cases runc itself can detect the appropriate value,
but it is considered to be there are some corner cases.
Signed-off-by: Akihiro Suda [email protected]
@cyphar @giuseppe @brauner (ref: opencontainers/runc#1833)