-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.7] cri: add deprecation warnings for deprecated CRI configs #9469
[release/1.7] cri: add deprecation warnings for deprecated CRI configs #9469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
People may misinterpret that containerd will only support the non-systemd cgroupfs driver. |
67c8561
to
ade8753
Compare
@AkihiroSuda fixed |
Thanks, could you update the commit message and the PR title too? |
Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
Signed-off-by: Samuel Karp <[email protected]>
ade8753
to
9d1bad6
Compare
@AkihiroSuda done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/cherrypick release/1.6 |
@samuelkarp: #9469 failed to apply on top of branch "release/1.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Part of #9312
This is the rest of the CRI configs that are deprecated other than
CriuPath
, which is separate (it's a runc option in the v2 runtimes).