vendor: golang.org/x/text v0.3.3 (CVE-2020-14040) #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: golang/text@19e5161...v0.3.3 includes a fix for [CVE-2020-14040][1] [1]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-14040 Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
perhaps needs to be back ported to 1.2.x and 1.3.x |
|
Build succeeded.
|
|
@estesp ok to add this to 1.3 (possibly 1.2) backports you think? |
AkihiroSuda
approved these changes
Jun 17, 2020
This was referenced Jun 17, 2020
|
How might this CVE affect 1.2.x or 1.3.x. The fix seems related to handling utf16. If this bug is manifesting in the network code, is there more details about it and how I think more justification is needed before backporting, especially to 1.2 with such a large diff. |
|
Similar thoughts from me in the 1.2 backport PR: #4331 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: golang/text@19e5161...v0.3.3
includes a fix for CVE-2020-14040