Update x/sys, x/net and bbolt modules to support Risc-V architecture #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
thaJeztah
reviewed
Jun 6, 2019
| @@ -41,7 +41,7 @@ github.com/containerd/ttrpc a5bd8ce9e40bc7c065a11c6936f4d032ce6bfa2b | |||
| github.com/syndtr/gocapability d98352740cb2c55f81556b63d4a1ec64c5a319c2 | |||
| gotest.tools v2.3.0 | |||
| github.com/google/go-cmp v0.2.0 | |||
| go.etcd.io/bbolt v1.3.2 | |||
| go.etcd.io/bbolt 2eb7227adea1d5cf85f0bc2a82b7059b13c2fa68 | |||
There was a problem hiding this comment.
do you know if there's a new release/tag planned for this?
There was a problem hiding this comment.
No idea on how their timeline for cutting new releases is. The complete bbolt test suite passes.
There was a problem hiding this comment.
Now I think it's fine!
|
Should I cleanup all _test files from the vendor repo? |
|
did you use the |
|
I tried twice with it and it cleaned a ton of modules saying they were not vendored breaking the build. |
|
Is your arch listed here yet? https://github.com/LK4D4/vndr/blob/master/build/syslist.go#L8 The builder may be failing to get the right set of dependencies and cleaning them because it doesn't understand RISC-V? Just a guess |
|
Thanks @estesp ! Since vndr built correctly never went thru my mind it required an update too. Just sent PR LK4D4/vndr#80. Even tho I used this newly built vndr, it still cleans lots of packages. I just changed the hash of x/sys, x/net and bbolt. Here is it's output: |
|
I wonder if @LK4D4 can help us here? Is this running on your device? I assume so given the 22m time vs. average 3-4min that I usually see.. if so, I'm guessing something is still not working with |
|
Same thing, I just installed vndr onto my Mac (go get https://github.com/LK4D4/vndr), cloned containerd, edited vendor.conf and ran Same happened on the hosr I run the NFS server. A lot got cleaned. Below is the log from my machine: |
|
I'll clean everything up and retest. Report back in a few minutes. |
|
I've had weird situations where that happened on my host (sometimes gopath related); not near my computer, but I could try running vndr in a clean golang container |
|
My bad, I checked-out a clean tree, edited vendor.conf and ran vndr on my Mac. It checked out the correct files and didn't delete all. On the RiscV board, it still removes tons of modules even on a clean checkout. @LK4D4 Any tips on what might be wrong? |
|
Build succeeded.
|
|
You are definitely very close now! The commit needs a |
|
Sorry--should be an |
Signed-off-by: CarlosEDP <[email protected]>
|
Might be fine now... sorry about the mess and thanks for the patience :D |
|
Vendor and DCO checks passed in CI; thanks for persisting. And congrats on the RISC-V effort; that's a huge undertaking; just looked at your status page. 😮 I did a (Linux) distro port to a new architecture in a prior life--a lot of blood, sweat, and tears! |
|
Build succeeded.
|
|
Thanks a lot Phil, it's been quite a ride and I'm quite accomplished on all that's been done and the feedback! |
Codecov Report
@@ Coverage Diff @@
## master #3328 +/- ##
==========================================
- Coverage 44.86% 40.25% -4.61%
==========================================
Files 113 76 -37
Lines 12338 10280 -2058
==========================================
- Hits 5535 4138 -1397
+ Misses 5953 5562 -391
+ Partials 850 580 -270
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3328 +/- ##
==========================================
- Coverage 44.86% 40.25% -4.61%
==========================================
Files 113 76 -37
Lines 12338 10280 -2058
==========================================
- Hits 5535 4138 -1397
+ Misses 5953 5562 -391
+ Partials 850 580 -270
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating projects using libraries that were recently updated to support Risc-V architecture.
Go upstream work is tracked on: golang/go#27532
Risc-V software support tracker on https://github.com/carlosedp/riscv-bringup
Signed-off-by: CarlosEDP [email protected]