Import zdfs package to support a tricky OCIv1 tgz format #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigVan
force-pushed
the
zdfs
branch
2 times, most recently
from
af91eda to
0d554ef
Compare
BigVan
changed the title
liulanzheng
reviewed
Apr 7, 2024
|
LGTM @WaberZhuang cc |
WaberZhuang
suggested changes
Apr 7, 2024
pkg/snapshot/overlay.go
Outdated
| if ok { | ||
| log.G(ctx).Infof("found imageRef: %s", img) | ||
| if err := os.WriteFile(filepath.Join(td, "image_ref"), []byte(img), 0644); err != nil { | ||
| log.G(ctx).Errorf("LSMD ERROR write imageRef '%s'. path: %s, err: %s", img, filepath.Join(td, "image_ref"), err.Error()) |
There was a problem hiding this comment.
nit: LSMD ERROR in the log is confusing, as is err.Error()
liulanzheng
reviewed
Apr 7, 2024
| if isOverlaybd, err := zdfs.PrepareOverlayBDSpec(ctx, key, id, o.snPath(id), oinfo, o.snPath); isOverlaybd { | ||
| log.G(ctx).Infof("sn: %s is an overlaybd layer", id) | ||
| } else if err != nil { | ||
| log.G(ctx).Errorf("prepare overlaybd spec failed(sn: %s): %s", id, err.Error()) |
There was a problem hiding this comment.
use ("%v", err) to print error？
liulanzheng
reviewed
Apr 7, 2024
pkg/snapshot/overlay.go
Outdated
| if ok { | ||
| log.G(ctx).Infof("found imageRef: %s", img) | ||
| if err := os.WriteFile(filepath.Join(path, "image_ref"), []byte(img), 0644); err != nil { | ||
| log.G(ctx).Errorf("write imageRef '%s'. path: %s, err: %s", img, filepath.Join(path, "image_ref"), err.Error()) |
There was a problem hiding this comment.
use ("%v", err) to print error？
Signed-off-by: Yifan Yuan <[email protected]>
AkihiroSuda
reviewed
Apr 13, 2024
| github.com/containerd/continuity v0.4.3 | ||
| github.com/containerd/go-cni v1.1.9 | ||
| github.com/containerd/log v0.1.0 | ||
| github.com/data-accelerator/zdfs v0.1.3 |
There was a problem hiding this comment.
The package lacks license
There was a problem hiding this comment.
Sorry...
I have added Apache license to the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add zdfs package import.
Packing the reference files of the overlaybd blob into the layer of the OCIv1 image; This enables the old version of containerd or other runtime (such as docker) to run overlaybd image
reference files like:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: