Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override entrypoint for jupyter command to /bin/sh #58

Closed
buvoli opened this issue Apr 2, 2020 · 2 comments
Closed

Override entrypoint for jupyter command to /bin/sh #58

buvoli opened this issue Apr 2, 2020 · 2 comments
Assignees
@buvoli
Labels
enhancement New feature or request

Comments

@buvoli
Copy link
Member

buvoli commented Apr 2, 2020

In order to allow all stacks with jupyter installed to be activated with cjr jupyter:start, the entrypoint for the job started jupyter:star should be set to "[/bin/sh","-c"].
@buvoli buvoli added the enhancement New feature or request label Apr 2, 2020
@buvoli buvoli self-assigned this Apr 2, 2020
@buvoli
Copy link
Member Author

buvoli commented Apr 2, 2020

entrypoint options was added as a comment in #2dd02294296f96a76d23be71f0e644ca638c6d17. However podman and docker accept different formats for --entrypoint command and docker will break if the line is actived. Once issue #46 is resolved, then these lines can be uncommented and this issue can be closed.

@buvoli
Copy link
Member Author

buvoli commented May 18, 2020

This should be added as an additional flag for the jupyter command (i.e. --override-entrypoint) since this default behavior would be undesirable for stacks with specially constructed entrypoints.

@buvoli buvoli closed this as completed in 63ebd7f May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buvoli buvoli

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@buvoli