Zoro fetchEpisodeSources and fetchEpisodeServers fixed #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riimuru
approved these changes
Oct 26, 2024
| ): IExtendedEpisodeServer | undefined { | ||
| const serverMap: { [key: string]: string } = { | ||
| [StreamingServers.VidStreaming]: 'HD-1', | ||
| [StreamingServers.VidCloud]: 'HD-2', |
There was a problem hiding this comment.
The function should accept multiple values like 'VidCloud' and 'VidStreaming' because the user won't know they are labeled as 'HD-1' or 'HD-2' to select them. It should also be case-insensitive. The function below should updated accordingly.
riimuru
reviewed
Oct 26, 2024
| throw err; | ||
| } | ||
| }; | ||
| // override fetchEpisodeSources = async ( |
There was a problem hiding this comment.
Remove this commented block
hello, Did you have this issue as me, I try to use node v20.18.0, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
= i fixed zoro fetchEpisodeSources and also added fetchEpisodeServers
Did you add tests for your changes?
= yes
If relevant, did you update the documentation?
= no already updated
Summary
Other information