Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

Support for the race detector #96

Closed
ardan-bkennedy opened this issue May 16, 2015 · 8 comments
Closed

Support for the race detector #96

ardan-bkennedy opened this issue May 16, 2015 · 8 comments

Comments

@ardan-bkennedy
Copy link

Having the ability to run gb build and gb test with the -race option. This is an important tool that everyone should be using.
@davecheney
Copy link
Contributor

Shouldn't be a problem but it is blocked by cgo support and figuring out
what to do hashing build tags to make conditional compilation sane.

On Sat, 16 May 2015 13:21 William Kennedy [email protected] wrote:

Having the ability to run gb build and gb test with the -race option. This
is an important tool that everyone should be using.

—
Reply to this email directly or view it on GitHub
#96.

@rmrio
Copy link

rmrio commented Jun 15, 2015

Any news, guys?

@davecheney
Copy link
Contributor

It's on the list, below finishing gb-vendor and cgo support.

On Mon, Jun 15, 2015 at 8:30 PM, rmr [email protected] wrote:

Any news, guys?

—
Reply to this email directly or view it on GitHub
#96 (comment).

@falzm
Copy link

falzm commented Jul 1, 2015

I would also like this to be implemented in gb build, please.

@dlclark
Copy link

dlclark commented Sep 29, 2015

I think the pre-reqs for this one are completed now. Any thoughts on this?

@davecheney
Copy link
Contributor

Yup, the big blocker was tag support which is now done.

On Wed, 30 Sep 2015 05:15 Doug Clark [email protected] wrote:

I think the pre-reqs for this one are completed now. Any thoughts on
this?

—
Reply to this email directly or view it on GitHub
#96 (comment).

@tylerstillwater
Copy link

Very excited about this. Just finished migrating my day job project to gb, and I miss running race on all my tests.

@sevein
Copy link

sevein commented Oct 5, 2015

Most of you guys probably know this 😄 but you can work around this limitation by updating GOPATH (GOPATH=$PROJECT_DIR/vendor:$PROJECT_DIR) and then running go {build,install,test} -race ./src/... , just in case someone gets stuck here.

@davecheney davecheney mentioned this issue Dec 6, 2015
Closed
davecheney added a commit that referenced this issue Dec 15, 2015
@davecheney
Add WithRace Context option
ae1a712 
Updates #96

Adds option to configure the context for a race build. This enables the
`race` build tag, and sets `Context.race`.
This was referenced Dec 15, 2015
Merged
Merged
davecheney added a commit that referenced this issue Dec 15, 2015
@davecheney
Add race detector support
cea3e3d 
Fixes #96

Adds the race detector you all know and love to gb.

Todo:
- [ ] Add support for rebuilding stdlib if -race support is not present.
- [ ] Add interlocks to restrict the race detector to certain amd64 for freebsd, linux, darwin, and linux.
- [ ] Make all binaries dependant on runtime/race.
- [ ] Add tests at cmd/gb as well as gb and gb/test.
@davecheney davecheney mentioned this issue Dec 15, 2015
Merged
5 tasks
davecheney added a commit that referenced this issue Dec 15, 2015
@davecheney
Add race detector support
259a6d8 
Fixes #96

Adds the race detector you all know and love to gb.

Todo:
- [ ] Add support for rebuilding stdlib if -race support is not present.
- [ ] Add interlocks to restrict the race detector to certain amd64 for freebsd, linux, darwin, and linux.
- [ ] Make all binaries dependant on runtime/race.
- [X] Add cmd/gb race test
- [ ] Add tests at cmd/gb as well as gb and gb/test.
davecheney added a commit that referenced this issue Dec 16, 2015
@davecheney
cmd/gb: refuse to run if -race support missing
e8ca5fd 
Fixes #494
Upate #96

If race support is missing, refuse to try to build, and give link to faq to help people install the race runtime.
davecheney added a commit that referenced this issue Dec 16, 2015
@davecheney
cmd/gb: refuse to run if -race support missing
bf86cee 
Fixes #494
Upate #96

If race support is missing, refuse to try to build, and give link to faq to help people install the race runtime.
@davecheney davecheney mentioned this issue Dec 16, 2015
Merged
davecheney added a commit that referenced this issue Dec 16, 2015
@davecheney
cmd/gb: refuse to run if -race support missing
bb1c315 
Fixes #494
Upate #96

If race support is missing, refuse to try to build, and give link to faq to help people install the race runtime.
davecheney added a commit that referenced this issue Dec 16, 2015
@davecheney
cmd/gb: refuse to run if -race support missing
165b8a0 
Fixes #494
Upate #96

If race support is missing, refuse to try to build, and give link to faq to help people install the race runtime.
davecheney added a commit that referenced this issue Dec 16, 2015
@davecheney
cmd/gb: refuse to run if -race support missing
ae38e4b 
Fixes #494
Upate #96

If race support is missing, refuse to try to build, and give link to faq to help people install the race runtime.
davecheney added a commit that referenced this issue Dec 16, 2015
@davecheney
cmd/gb: refuse to run if -race support missing
e15e7a6 
Fixes #494
Upate #96

If race support is missing, refuse to try to build, and give link to faq to help people install the race runtime.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@davecheney @tylerstillwater @sevein @falzm @ardan-bkennedy @dlclark @rmrio