Error last argument is considered chainable

consistence · Sep 22, 2017 · 5132789 · 5132789
1 parent 5b2879d
commit 5132789
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/Consistence/Sniffs/Exceptions/ExceptionDeclarationSniff.php b/Consistence/Sniffs/Exceptions/ExceptionDeclarationSniff.php
@@ -116,6 +116,7 @@ private function checkThatExceptionIsChainable(PhpCsFile $phpcsFile, int $classP
 		if (
 			$lastArgument->getTypeHint() !== '\Throwable'
 			&& !StringHelper::endsWith($lastArgument->getTypeHint(), 'Exception')
+			&& !StringHelper::endsWith($lastArgument->getTypeHint(), 'Error')
 		) {
 			$phpcsFile->addError(sprintf(
 				'Exception is not chainable. It must have optional \Throwable as last constructor argument and has "%s".',

diff --git a/tests/Sniffs/Exceptions/ExceptionDeclarationSniffTest.php b/tests/Sniffs/Exceptions/ExceptionDeclarationSniffTest.php
@@ -153,6 +153,15 @@ public function testExceptionWithCustomExceptionArgumentIsChainable()
 		$this->assertNoSniffError($resultFile, 10);
 	}
 
+	public function testExceptionWithErrorArgumentIsChainable()
+	{
+		$resultFile = $this->checkFile(__DIR__ . '/data/ErrorArgumentChainableConstructorException.php', [
+			'exceptionsDirectoryName' => 'data',
+		]);
+
+		$this->assertNoSniffError($resultFile, 10);
+	}
+
 	public function testExceptionWithNonchainableConstructorIsNotChainable()
 	{
 		$resultFile = $this->checkFile(__DIR__ . '/data/NonChainableConstructorException.php', [

diff --git a/tests/Sniffs/Exceptions/data/ErrorArgumentChainableConstructorException.php b/tests/Sniffs/Exceptions/data/ErrorArgumentChainableConstructorException.php
@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Consistence\Sniffs\Exceptions;
+
+class ErrorArgumentChainableConstructorException extends \Exception
+{
+
+	public function __construct(string $foo, \TypeError $e)
+	{
+		parent::__construct($foo, 0, $e);
+	}
+
+}