Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume maintainership of celery-php #1

Open
4 tasks
ergonlogic opened this issue Nov 30, 2021 · 4 comments
Open
4 tasks

Assume maintainership of celery-php #1

ergonlogic opened this issue Nov 30, 2021 · 4 comments

Comments

@ergonlogic
Copy link
Member

Per gjedeer#125, @gjedeer wrote:

@ergonlogic yeah, I should probably archive this project as it's unmaintained. Maybe one of the forks is kept updated?

If you find something that works for up-to-date celery, let me know please, so that I can tell other users to switch.

My colleagues and I at Consensus are using this package in a FLOSS project, and so could take on at least some minimal maintenance.

To that end, here are some tasks we should probably undertake:

  • Enable CI (and ensure that it's passing)
  • Publish a new package to Packagist
  • Update README and other docs
  • Ask @gjedeer to point to this project from gjedeer/celery-php

We generally prefer to work on Gitlab, so we may want to move the project over there, and make this a mirror. This'd effect most of the tasks above, and so should probably be decided first.

@gjedeer
Copy link

gjedeer commented Dec 1, 2021

Glad to see this happen, I'll be happy to cooperate with moving.

By the way, @ergonlogic , you've had commit rights to the old repository for a few years.

@jooola
Copy link

jooola commented Jan 13, 2022

Hey, will this fork get it's own name and package (consensus-enterprises/celery-php) ? Or should I grab the package using git directly ?

I've had some trouble with the new amqplib version which renamed some of it's connectors. I also have some issues with the new celery V5 rpc result backend.

I am happy to provide some patches attempts, but I wonder if this project is living ?

@Ambient-Impact
Copy link
Member

I think taking over maintainership and using our own namespace for the Composer package like @jooola suggests would be the best way forward. I'm running into a fatal error when trying to upgrade php-amqplib/php-amqplib 2.x to 3.x for Aegir 5 that seems originate with celery-php, which I assume are the same errors @jooola is running into.

@Ambient-Impact
Copy link
Member

Alright, so after poking around the php-amqplib/php-amqplib codebase, I realized that AMQPConnection has been deprecated going back to at least 2014, and probably farther back, so just replacing it with AMQPStreamConnection seems to fix the immediate problems and it now seems to work on php-amqplib/php-amqplib:^3.6.2. This should not break compatibility with php-amqplib/php-amqplib:^2.6.

php-amqplib/php-amqplib@64eb289#diff-f335edbdd39701e7e2a7b44a647a54e0010f15508a06baca2a3db1836549f3eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants