Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpacker to v4. #77

Merged
merged 5 commits into from
Jan 23, 2019
Merged

Upgrade webpacker to v4. #77

merged 5 commits into from
Jan 23, 2019

Conversation

connorshea
Copy link
Owner

@connorshea connorshea commented Jan 22, 2019 •
edited
Loading

I'm not able to get it working with the CSS, but the JavaScript does seem to work fine. Works now!

@connorshea connorshea mentioned this pull request Jan 22, 2019
Closed
@connorshea connorshea changed the title WIP: Upgrade webpacker to v4. Upgrade webpacker to v4. Jan 22, 2019
@connorshea connorshea mentioned this pull request Jan 22, 2019
Merged
maschwenk
maschwenk reviewed Jan 22, 2019
View reviewed changes
config/webpacker.yml Outdated Show resolved Hide resolved
config/webpack/environment.js Show resolved Hide resolved
@connorshea connorshea merged commit 2da4a27 into master Jan 23, 2019
@connorshea connorshea deleted the upgrade-webpacker branch January 23, 2019 00:59
@connorshea connorshea mentioned this pull request Jan 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschwenk maschwenk maschwenk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorshea @maschwenk