Remove WithTelemetry option in favor of connect.WithInterceptors(otelconnect.NewInterceptor()) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcarp
force-pushed
the
feat/interceptor-only
branch
2 times, most recently
from
92e89a9 to
cd2b681
Compare
joshcarp
force-pushed
the
feat/interceptor-only
branch
from
cd2b681 to
e162a92
Compare
doriable
reviewed
Jan 17, 2023
Co-authored-by: Doria Keung <[email protected]>
akshayjshah
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Two suggestions:
- If Doria leans toward
NewInterceptor, that's fine with me - let's change. - Let's export an
otelconnect.Interceptorstruct, and have the exported constructor return an*Interceptor. In general, let's return concrete types instead of interfaces (with the exception of constructors for functional options).
joshcarp
changed the title
doriable
approved these changes
Jan 18, 2023
akshayjshah
pushed a commit
that referenced
this pull request
Jul 26, 2023
The only use case we have of using this package is using a number of Interceptors instead of just the `WithTelemetry` option. It's anticipated that if a project is using connect-opentelemetry-go the chances are that it's probably also using other interceptors. In that case it makes sense to expose a `New` function that returns an `type interceptor struct` that can be plugged into the existing interceptor plumbing. The only difference this makes to existing projects that are using `WithTelemetry` is that they now need to use `connect.WithInterceptor(otelconnect.New())` Fixes: https://github.com/bufbuild/connect-opentelemetry-go/issues/21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only use case we have of using this package is using a number of Interceptors instead of just the
WithTelemetryoption. It's anticipated that if a project is using connect-opentelemetry-go the chances are that it's probably also using other interceptors. In that case it makes sense to expose aNewfunction that returns antype interceptor structthat can be plugged into the existing interceptor plumming.The only difference this makes to existing projects that are using
WithTelemetryis that they now need to useconnect.WithInterceptor(otelconnect.New())Fixes: https://github.com/bufbuild/connect-opentelemetry-go/issues/21