Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RFC-002: CORS and authn for Go #123

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Add RFC-002: CORS and authn for Go #123

merged 2 commits into from
Jan 12, 2024

Conversation

akshayjshah
Copy link
Member

Add an RFC for creating CORS and authentication packages for users of
Connect in Go.

@akshayjshah
Add RFC-002: CORS and authn for Go
77d347c 
Add an RFC for creating CORS and authentication packages for users of
Connect in Go.
@akshayjshah akshayjshah requested a review from jhump January 11, 2024 22:51
@vercel Vercel
Copy link

vercel bot commented Jan 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 5:45pm

@akshayjshah
Copy link
Member Author

I've added the current maintainers of the various Connect implementations as reviewers.

I'm formally in favor of adding these small quality-of-life packages to the Connect project. Formally approving this RFC requires approval from an additional 5 maintainers (since we have a total of 10). Maintainers, please indicate support or opposition using Github's code review!

mattrobenolt
mattrobenolt approved these changes Jan 11, 2024
View reviewed changes
Copy link

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, these make sense to me as something to provide as first class support. They are pretty common patterns by most applications. I think having these too will help guide users of Connect on the patterns for implementing more custom things that fall outside of interceptors too.

docs/governance/rfc/002-go-cors-authn.md Show resolved Hide resolved
docs/governance/rfc/002-go-cors-authn.md Outdated Show resolved Hide resolved
docs/governance/rfc/002-go-cors-authn.md Show resolved Hide resolved
pkwarren
pkwarren approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@pkwarren pkwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited to have both of these packages available!

docs/governance/rfc/002-go-cors-authn.md Outdated Show resolved Hide resolved
timostamm
timostamm approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing a source of truth for CORS setup, and a standardized mechanism for propagating identity, are both great additions in my book.

👍 for adding the features as separate modules. This should keep connect-go as slim and flexible as possible.

@akshayjshah akshayjshah merged commit 9832b88 into main Jan 12, 2024
4 checks passed
@akshayjshah akshayjshah deleted the ajs/rfc branch January 12, 2024 19:06
@akshayjshah akshayjshah mentioned this pull request Jan 12, 2024
Merged
akshayjshah added a commit that referenced this pull request Jan 12, 2024
@akshayjshah
Add Go module support for cors and authn (#124)
33ddf51 
Add the plumbing required to resolve the connectrpc.com/authn and
connectrpc.com/cors import paths (proposed and approved in #123).
@srikrsna-buf srikrsna-buf mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrobenolt mattrobenolt mattrobenolt approved these changes

@srikrsna-buf srikrsna-buf srikrsna-buf approved these changes

@timostamm timostamm timostamm approved these changes

@bufdev bufdev bufdev approved these changes

@rebello95 rebello95 rebello95 approved these changes

@jhump jhump jhump approved these changes

@smaye81 smaye81 smaye81 approved these changes

@pkwarren pkwarren pkwarren approved these changes

@eseay eseay Awaiting requested review from eseay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@akshayjshah @mattrobenolt @pkwarren @smaye81 @jhump @rebello95 @bufdev @timostamm @srikrsna-buf