Update README.md adapting v2 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Thanks for the fix! Do you mind making the same change in packages/connect-playwright/README.md?
Happy to merge your PR, but we need you to sign your commits. See CONTRIBUTING.md and the "DCO" check below for details.
API for `mock.rpc` has been changed accepting only method and mocked message. See examples as reference. Signed-off-by: Tu Hoang <[email protected]>
Signed-off-by: Tu Hoang <[email protected]>
|
@timostamm Done. Thanks for pointing out the sign-off. |
timostamm
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for
mock.rpchas been changed accepting only method and mocked message. See examples as reference.