Fix release build #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run 'make releaselocal' to verify in CI that a Maven release (with docs) works successfully.
pkwarren
commented
Sep 8, 2023
| @@ -38,6 +38,8 @@ jobs: | |||
| git diff-index --quiet HEAD -- | |||
| - name: Build project | |||
| run: make build | |||
| - name: Install to local repository | |||
| run: make releaselocal | |||
There was a problem hiding this comment.
Added this to CI step so we'll know if the release build is likely to fail. The first commit to this PR only had this change (and you can see it failed the build).
There was a problem hiding this comment.
Can you make the name clearer to indicate intent? It's not obvious to me based on the description there now
| @@ -7,7 +7,7 @@ junit = "4.13.2" | |||
| kotlin = "1.6.21" | |||
| kotlinpoet = "1.12.0" | |||
| ktlint = "0.46.0" | |||
| mavenplugin = "0.22.0" | |||
| mavenplugin = "0.24.0" | |||
There was a problem hiding this comment.
Bump to a newer plugin. We can't bump to the latest without also bumping to a newer version of the Kotlin plugin (which isn't very straightforward). I'd like to start with this to get a release out.
rebello95
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run 'make releaselocal' to verify in CI that a Maven release (with docs) works successfully.