-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generateCoroutineMethods
plugin option for generating unary callback signatures
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildbreaker
changed the title
Add
Add Feb 27, 2023
callback_signature
plugin optioncallbackSignature
plugin option
buildbreaker
changed the title
Add
Add Feb 27, 2023
callbackSignature
plugin optioncallbackSignature
plugin option for generating callback signatures
buildbreaker
changed the title
Add
Add Feb 27, 2023
callbackSignature
plugin option for generating callback signaturescallbackSignature
plugin option for generating unary callback signatures
jhump
approved these changes
Feb 27, 2023
rebello95
reviewed
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Would it make sense to duplicate crosstests for callbacks vs coroutines (we do in connect-swift)?
- Should we add an option to turn off the coroutine API generation (like we have for Swift async/await) so that users don't unnecessarily generate unused code?
protoc-gen-connect-kotlin/src/main/kotlin/build/buf/protocgen/connect/Generator.kt
Outdated
Show resolved
Hide resolved
rebello95
approved these changes
Feb 27, 2023
buildbreaker
changed the title
Add
Add Feb 27, 2023
callbackSignature
plugin option for generating unary callback signaturesgenerateCoroutineMethods
plugin option for generating unary callback signatures
buildbreaker
changed the title
Add
Add Feb 27, 2023
generateCoroutineMethods
plugin option for generating unary callback signaturesgenerateCoroutineMethods
plugin option for generating unary callback signatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
callbackSignature
option for call sites without kotlin coroutines. This change basically exposes the wiring from the generated code to the underlying unary request callback method.generateCallbackMethods
false
generateCoroutineMethods
true
Interface example:
Implementation: