Attempt to fix plugin release to github #43
Conversation
During the last release, we still encountered an issue in the plugin release step. Ensure we set the releaseVersion property when running the gradle build.
| tag=$(git describe --tags --abbrev=0 --exact-match) | ||
| release_version="${tag:1}" | ||
| echo "release_version=${release_version}" >> "$GITHUB_ENV" | ||
| export ORG_GRADLE_PROJECT_releaseVersion="${release_version}" |
There was a problem hiding this comment.
We need to set this prior to running the build to ensure the artifact has the right version number.
| tag=$(git describe --tags --abbrev=0 --exact-match) | ||
| release_version="${tag:1}" | ||
| echo "release_version=${release_version}" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
release_version is used in the next step so we need to set it in the environment.
There was a problem hiding this comment.
ye, was wondering about that, thanks for the explanation!
There was a problem hiding this comment.
cool - more as notes for myself, this sets a project property in the environment which then is picked up in the gradle publish. 👍
|
Unfortunately this didn't completely fix the issue - #44 should resolve it. I do think however there is merit in improving this in two ways:
|
|
Addressed item 2 in PR #45. Users wanting to download the artifacts in the 0.1.5/0.1.6/0.1.7 releases can download from https://repo1.maven.org/maven2/build/buf/protoc-gen-connect-kotlin/ |
During the last release, we still encountered an issue in the plugin release step. Ensure we set the releaseVersion property when running the gradle build.