Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request stream close on stream pause #36

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Fix request stream close on stream pause #36

merged 2 commits into from
Apr 12, 2023

Conversation

buildbreaker
Copy link
Contributor

@buildbreaker buildbreaker commented Apr 6, 2023 •
edited
Loading

Resolves #31

@buildbreaker buildbreaker requested a review from rebello95 April 12, 2023 22:29
@buildbreaker buildbreaker merged commit 5da30f1 into main Apr 12, 2023
@buildbreaker buildbreaker deleted the achiu/fix-request-stream-close-on-stream-pause branch April 12, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebello95 rebello95 rebello95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing catch to finally in PipeDuplexRequestBody.forConsume prevents long-lived streaming connections
2 participants
@buildbreaker @rebello95