Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine protoc version from protobuf version #312

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

pkwarren
Copy link
Contributor

@pkwarren pkwarren commented Aug 5, 2024

The protoc version is the same value as the '[versions] protobuf' in the Gradle version catalog, without the major version. Update the Makefile to automatically keep these versions in sync, removing a manual step of updating the Makefile whenever dependabot updates protobuf.

@pkwarren pkwarren requested a review from jhump August 5, 2024 15:34
The protoc version is the same value as the '[versions] protobuf' in the
Gradle version catalog, without the major version. Update the Makefile
to automatically keep these versions in sync, removing a manual step of
updating the Makefile whenever dependabot updates protobuf.

Signed-off-by: Philip K. Warren <[email protected]>
@pkwarren pkwarren force-pushed the pkw/reduce-manual-dependabot-steps branch from c0c852c to 45c8c21 Compare August 5, 2024 16:35
@@ -11,7 +11,10 @@ CACHE := .tmp/cache
LICENSE_HEADER_YEAR_RANGE := 2022-2023
LICENSE_HEADER_VERSION := v1.34.0
CONFORMANCE_VERSION := v1.0.2
PROTOC_VERSION ?= 27.2
PROTOC_VERSION ?= $(shell yq '.versions.protobuf' gradle/libs.versions.toml | cut -d'.' -f2-)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoah. I didn't realize yq understood toml files.

@pkwarren pkwarren merged commit df659a3 into main Aug 6, 2024
9 checks passed
@pkwarren pkwarren deleted the pkw/reduce-manual-dependabot-steps branch August 6, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants