Determine protoc version from protobuf version #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protoc version is the same value as the '[versions] protobuf' in the Gradle version catalog, without the major version. Update the Makefile to automatically keep these versions in sync, removing a manual step of updating the Makefile whenever dependabot updates protobuf. Signed-off-by: Philip K. Warren <[email protected]>
pkwarren
force-pushed
the
pkw/reduce-manual-dependabot-steps
branch
from
c0c852c to
45c8c21
Compare
jhump
reviewed
Aug 5, 2024
| @@ -11,7 +11,10 @@ CACHE := .tmp/cache | |||
| LICENSE_HEADER_YEAR_RANGE := 2022-2023 | |||
| LICENSE_HEADER_VERSION := v1.34.0 | |||
| CONFORMANCE_VERSION := v1.0.2 | |||
| PROTOC_VERSION ?= 27.2 | |||
| PROTOC_VERSION ?= $(shell yq '.versions.protobuf' gradle/libs.versions.toml | cut -d'.' -f2-) | |||
There was a problem hiding this comment.
Whoah. I didn't realize yq understood toml files.
jhump
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protoc version is the same value as the '[versions] protobuf' in the Gradle version catalog, without the major version. Update the Makefile to automatically keep these versions in sync, removing a manual step of updating the Makefile whenever dependabot updates protobuf.